Skip to content

feat(context): context hooks with /context hooks #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hayemaxi merged 1 commit into from
Apr 14, 2025
Merged

feat(context): context hooks with /context hooks #1218

hayemaxi merged 1 commit into from
Apr 14, 2025

Conversation

@hayemaxi
Copy link
Contributor

@hayemaxi hayemaxi commented Apr 13, 2025 •
edited
Loading

Follow up to: #1176
RFC: #1050

  • Add new command /context hooks
    • subcommands to add/remove and enable/disable hooks
  • Context hooks are called then added to the beginning of the chat history as context, or to each prompt, depending on what is chosen.
image image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 45.69892% with 202 lines in your changes missing coverage. Please review.

Project coverage is 14.04%. Comparing base (06c2e21) to head (e28bb3d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/q_cli/src/cli/chat/mod.rs 9.69% 145 Missing and 4 partials ⚠️
crates/q_cli/src/cli/chat/command.rs 61.24% 49 Missing and 1 partial ⚠️
crates/q_cli/src/cli/chat/conversation_state.rs 96.15% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
+ Coverage   13.96%   14.04%   +0.07%     
==========================================
  Files        2365     2366       +1     
  Lines      204869   205444     +575     
  Branches   185233   185808     +575     
==========================================
+ Hits        28618    28845     +227     
- Misses     174846   175175     +329     
- Partials     1405     1424      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hayemaxi hayemaxi force-pushed the context-hooks-integrate branch 3 times, most recently from 381470b to f903860 Compare April 14, 2025 03:06
@hayemaxi hayemaxi marked this pull request as ready for review April 14, 2025 03:10
@hayemaxi hayemaxi requested a review from a team April 14, 2025 03:10
@hayemaxi hayemaxi force-pushed the context-hooks-integrate branch 2 times, most recently from a60137f to 3df7a31 Compare April 14, 2025 15:17
GoodluckH
GoodluckH approved these changes Apr 14, 2025
View reviewed changes
@hayemaxi
feat(context): context hooks with /context hooks
e28bb3d 
Follow up to: aws#1176
RFC: aws#1050

- Add new command `/context hooks`
  - subcommands to add/remove and enable/disable hooks
- Context hooks are called then added to the beginning of the chat history as context, or to each prompt, depending on what is chosen.
@hayemaxi hayemaxi force-pushed the context-hooks-integrate branch from 3df7a31 to e28bb3d Compare April 14, 2025 20:03
@hayemaxi hayemaxi merged commit 82d91ff into aws:main Apr 14, 2025
10 checks passed
jsamuel1 pushed a commit that referenced this pull request Apr 15, 2025
@hayemaxi @jsamuel1
feat(context): context hooks with /context hooks (#1218)
bf71f40 
Follow up to: #1176
RFC: #1050

- Add new command `/context hooks`
  - subcommands to add/remove and enable/disable hooks
- Context hooks are called then added to the beginning of the chat history as context, or to each prompt, depending on what is chosen.
@chaynabors chaynabors mentioned this pull request Apr 21, 2025
Closed
This was referenced Apr 30, 2025
Merged
Closed
Merged
@brandonskiser brandonskiser mentioned this pull request May 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GoodluckH GoodluckH GoodluckH approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hayemaxi @codecov-commenter @GoodluckH